Crashing script from t3h hell

I am so puzzled :S

from WinCustomize Forums
Hello!

I've spent last couple of days programming a new project and it was going so well I was really enjoying the work.

And then, while testing one of the features it crashed. Nothing special, this happens while the script is in developement, so I went and checked it for mistakes. But to my amazement, after quite some time I couldn't locate the problem.

This is the bit where DesktopX Builder crashes in flames:

Code: vbscript
  1. Dim HKEY_entrynum
  2. Dim HKEY_written_value
  3. Dim HKEY_type
  4. Dim HKEY_visible 'is the entry visible or not (v-visible h-hidden)
  5. Dim bar_counter
  6. Dim file 'only file's name
  8. Sub Reading_HKEY(x)
  9. m = msgbox("Reading_HKEY"&x,0,"Executro]list ")
  10. Set Sh = CreateObject("WScript.Shell")
  11. ' Defining:
  12. ' -HKEY_written_value
  13. HKEY_written_value = Sh.RegRead("HKEY_LOCAL_MACHINE\SOFTWARE\Forge7\FIncogniter\index")
  14. Set Sh = Nothing
  15. m = msgbox("Read HKEY_written value= "&HKEY_written_value,0,"Executro]list ")
  16. If HKEY_written_value = "" Or HKEY_written_value ="0|" Then
  17. m = msgbox("No data available for extraction.",0,"Executro]list ")
  18. Else
  19. If x=1 Then
  20. m=msgbox("create_list(1)",0,"Executro]list ")
  21. Call create_list(1)
  22. ElseIf x=2 Then
  23. m=msgbox("delete_list(2)",0,"Executro]list ")
  24. Call delete_list(2)
  25. ElseIf x=3 Then
  26. m=msgbox("delete_list(3)",0,"Executro]list ")
  27. Call delete_list(3)
  28. End If
  29. End If
  30. End Sub
  32. Sub create_list(x)
  33. bar_counter = 0 'resets bar counter (counts entrys created)
  34. 'DesktopX.Object("EntryBackground").height = 0 'resets height of the list parent object
  35. 'DesktopX.Object("EntryBackground").visible = True
  36. x=split(HKEY_written_value,"|")'segments HKEY to number of entrys and entrys data
  37. HKEY_entrynum = x(0) 'sets number of entrys
  38. 'DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = HKEY_entrynum
  39. DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = 0
  40. m = msgbox("Number of actual entrys = "&DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys,0,"Executro]list ")
  41. m = msgbox("Number of entrys in HKEY = "&HKEY_entrynum,0,"Executro]list ")
  42. 'If DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = 0 Then
  43. Do
  44. m = msgbox("Just entered the loop",0,"Executro]list ")
  45. bar_counter = bar_counter+1
  46. 'splitting entry string to gather data
  47. y=split(x(HKEY_entrynum),"*")
  48. 'Getting wether entry is visible or not (v/h)
  49. HKEY_visible=y(0)
  50. 'Getting the type of entry
  51. HKEY_type=y(1)
  52. 'Getting full entry name
  53. HKEY_file=y(2)
  54. 'Getting only entry's name
  55. z = InStrRev(HKEY_file,"\","-1")'now x is the number where string needs to be cut
  56. q = Len(HKEY_file)
  57. file = Right(HKEY_file,(q-z))'This is only entry's name
  58. HKEY_entrynum = HKEY_entrynum - 1 'ensures that during next pass new entry will be managed
  59. 'now cloning objects:
  60. 'EntryParent*x
  61. DesktopX.Object("EntryParent*0").clone ("EntryParent*"&bar_counter), DesktopX.Object("EntryParent*0").left, (-DesktopX.Object("EntryParent*0").height+(bar_counter*DesktopX.Object("EntryParent*0").height))
  62. 'm = msgbox("HKEY_visible: "&DesktopX.ScriptObject("EntryParent*"&bar_counter).HKEY_visible,0,"Executor]list ")
  63. DesktopX.ScriptObject("EntryParent*"&bar_counter).HKEY_visible = HKEY_visible
  64. 'm = msgbox("HKEY_visible: "&DesktopX.ScriptObject("EntryParent*"&bar_counter).HKEY_visible,0,"Executor]list ")
  65. DesktopX.ScriptObject("EntryParent*"&bar_counter).HKEY_type = HKEY_type
  66. DesktopX.ScriptObject("EntryParent*"&bar_counter).HKEY_file = HKEY_file
  67. DesktopX.ScriptObject("EntryParent*"&bar_counter).file = file
  68. 'EntryChild*x
  69. DesktopX.Object("EntryChild*0").clone ("EntryChild*"&bar_counter), DesktopX.Object("EntryChild*0").left, DesktopX.Object("EntryChild*0").top
  70. DesktopX.Object("EntryChild*"&bar_counter).parent = DesktopX.Object("EntryParent*"&bar_counter)
  71. 'EntryToolboxMask*x
  72. DesktopX.Object("EntryToolboxMask*0").clone ("EntryToolboxMask*"&bar_counter), DesktopX.Object("EntryToolboxMask*0").left, DesktopX.Object("EntryToolboxMask*0").top
  73. DesktopX.Object("EntryToolboxMask*"&bar_counter).parent = DesktopX.Object("EntryParent*"&bar_counter)
  74. 'EntryToolbox*x
  75. DesktopX.Object("EntryToolbox*0").clone ("EntryToolbox*"&bar_counter), DesktopX.Object("EntryToolbox*0").left, DesktopX.Object("EntryToolbox*0").top
  76. DesktopX.Object("EntryToolbox*"&bar_counter).parent = DesktopX.Object("EntryToolboxMask*"&bar_counter)
  77. 'EntryText*x
  78. DesktopX.Object("EntryText*0").clone ("EntryText*"&bar_counter), DesktopX.Object("EntryText*0").left, DesktopX.Object("EntryText*0").top
  79. DesktopX.Object("EntryText*"&bar_counter).parent = DesktopX.Object("EntryChild*"&bar_counter)
  80. DesktopX.Object("EntryText*"&bar_counter).text = file
  81. 'EntryVisibility*x
  82. DesktopX.Object("EntryVisibility*0").clone ("EntryVisibility*"&bar_counter), DesktopX.Object("EntryVisibility*0").left, DesktopX.Object("EntryVisibility*0").top
  83. DesktopX.Object("EntryVisibility*"&bar_counter).parent = DesktopX.Object("EntryToolbox*"&bar_counter)
  84. If HKEY_visible = "v" Then
  85. DesktopX.ScriptObject("EntryVisibility*"&bar_counter).switcher = "v"
  86. DesktopX.ScriptObject("EntryVisibility*"&bar_counter).active = True
  87. DesktopX.Object("EntryVisibility*"&bar_counter).ExecuteCommand
  88. End If
  89. 'EntryType*x
  90. DesktopX.Object("EntryType*0").clone ("EntryType*"&bar_counter), DesktopX.Object("EntryType*0").left, DesktopX.Object("EntryType*0").top
  91. DesktopX.Object("EntryType*"&bar_counter).parent = DesktopX.Object("EntryChild*"&bar_counter)
  92. DesktopX.Object("EntryType*"&bar_counter).state = HKEY_type
  93. 'EntryRun*x
  94. DesktopX.Object("EntryRun*0").clone ("EntryRun*"&bar_counter), DesktopX.Object("EntryRun*0").left, DesktopX.Object("EntryRun*0").top
  95. DesktopX.Object("EntryRun*"&bar_counter).parent = DesktopX.Object("EntryToolbox*"&bar_counter)
  96. 'EntryRemove*x
  97. DesktopX.Object("EntryRemove*0").clone ("EntryRemove*"&bar_counter), DesktopX.Object("EntryRemove*0").left, DesktopX.Object("EntryRemove*0").top
  98. DesktopX.Object("EntryRemove*"&bar_counter).parent = DesktopX.Object("EntryToolbox*"&bar_counter)
  99. 'EntryFolder*x
  100. DesktopX.Object("EntryFolder*0").clone ("EntryFolder*"&bar_counter), DesktopX.Object("EntryFolder*0").left, DesktopX.Object("EntryFolder*0").top
  101. DesktopX.Object("EntryFolder*"&bar_counter).parent = DesktopX.Object("EntryToolbox*"&bar_counter)
  102. DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys+1
  103. Loop until HKEY_entrynum=0
  104. m = msgbox("Done compiling the list",0,"Executor]list ")
  105. x="1"
  106. y="1"
  107. z="1"
  108. m = msgbox("x ="&x&vbnewline&"y ="&y&vbnewline&"z ="&z,0,"Executor]list ")
  109. End Sub
  111. Sub delete_list(x)
  112. If DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = 0 Then
  113. m = msgbox("(=0)number_of_actual_entrys = "&number_of_actual_entrys,0,"Executro]list ")
  114. Else
  115. m = msgbox("(<>0)number_of_actual_entrys = "&number_of_actual_entrys,0,"Executro]list ")
  116. 'y=split(HKEY_written_value,"|")'segments HKEY to number of entrys and entrys data
  117. 'HKEY_entrynum = y(0) 'sets number of entrys
  119. 'This is not hkey value but rather the real value!
  120. HKEY_entrynum = DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys
  121. If x = 3 Then
  122. 'HKEY_entrynum = HKEY_entrynum-1 ' I just removed this one
  123. End If
  124. m = msgbox("HKEY_entrynum = "&HKEY_entrynum,0,"Executro]list ")
  125. Do
  126. DesktopX.Object("EntryFolder*"&HKEY_entrynum).delete
  127. DesktopX.Object("EntryRemove*"&HKEY_entrynum).delete
  128. DesktopX.Object("EntryVisibility*"&HKEY_entrynum).delete
  129. DesktopX.Object("EntryRun*"&HKEY_entrynum).delete
  130. DesktopX.Object("EntryText*"&HKEY_entrynum).delete
  131. DesktopX.Object("EntryType*"&HKEY_entrynum).delete
  132. DesktopX.Object("EntryToolbox*"&HKEY_entrynum).delete
  133. DesktopX.Object("EntryToolboxMask*"&HKEY_entrynum).delete
  134. DesktopX.Object("EntryChild*"&HKEY_entrynum).delete
  135. DesktopX.Object("EntryParent*"&HKEY_entrynum).delete
  137. HKEY_entrynum = HKEY_entrynum-1
  138. DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys = DesktopX.ScriptObject("EntryBackground").number_of_actual_entrys-1
  139. Loop until HKEY_entrynum = 0
  141. If x = 3 Then
  142. m = msgbox("(1)Just deleted the list, now calling Reading_HKEY(1)",0,"Executro]list ")
  143. Call Reading_HKEY(1)
  144. End If
  145. End If
  146. If x = 3 Then
  147. m = msgbox("(pass one)(2)Just deleted the list, now calling Reading_HKEY(1)"&vbnewline&"x = "&x,0,"Executro]list ")
  148. If x = 3 Then
  149. m = msgbox("(pass two)(3)Just deleted the list, now calling Reading_HKEY(1)"&vbnewline&"x = "&x,0,"Executro]list ")
  150. Call Reading_HKEY(1)
  151. End If
  152. End If
  153. End Sub

(Some things are unnecessary, but I added them to see if they would help...)
Now it works like this, this script is assigned to an object and it is called by others depending on what needs to be done.

This is how it is supposed to work:
1. Sub delete_list(x) is called form another object.
2. Sub ends and calls Sub Reading_HKEY(1)
3. Sub ends and calls Sub create_list(x)
4. Sub ends and that concludes the operation.

However, when launched this happens:
1. Sub delete_list(x) is called form another object.
2. Sub ends and calls Sub Reading_HKEY(1)
3. Sub ends and calls Sub create_list(x)
*now watch closely
4. it doesn't call Sub delete_list(x) but it immediately jumps to somewhere around line(140) although it wasn't even supposed to do that. After that, despite the "If" regulation which should stop the flow, it calls Sub Reading_HKEY(1), and then after reaching the end DesktopX Builder crashes.

Now just to make me even more confused, sometimes it even works (if i try Calling different Subs outside the object) but ultimately it just crashes.

I tried all sorts of things, I even tried moving one sub to another object, even removing entire contents of the sub except the crucial part, and it still wouldn't work and crash in the same or similar manner.

Now can anyone find the problem/bug or at least suggest a solution? I can even send you entire program if you think that would help.

If anyone has any, and I mean any idea, please post it here, so I can try to fix this bug.

P.S. thank you for reading this :)
skinning
3,084 views 7 replies
Reply #1 from WinCustomize Forums Top
Have you cleared the DesktopX cache?
Reply #2 from WinCustomize Forums Top
I got nothing. The sub looks fine to me. If you want send it to me gmail account sirsmiley001 and I'll have a look at it. I'm always up for a challenge! ;)

Something I've been doing lately is scripting a text object at each step which has helped in debugging.
Ashes of the Singularity II
Reply #3 from WinCustomize Forums Top

Have you cleared the DesktopX cache?
End of quote


Nope, how do I do that?

Just sent you the mail SirSmiley, hope you'll find the solution.
Reply #4 from WinCustomize Forums Top

Have you cleared the DesktopX cache?



Nope, how do I do that?
End of quote


Try reading CorkyO's article found here. WWW Link

It's a good idea to clear the cache whenever DesktopX crashes as can occur when writing and debugging scripts. The desktopx cache is where the current theme is kept and when it becomes buggy DX tends to crash. Clearing the cache solves this problem.
Reply #5 from WinCustomize Forums Top
Heh I actually once traced this folder (current theme) because I was curious where DX extracted desktops ^^

Anyhow, i cleared the cache, but my dear project blazed into a fireball again...
Reply #6 from WinCustomize Forums Top
The error that seems to crash it is line 63 subscript 1 but, this for some reason happens on removing (trying to remove) the last item from the list. The last item on delete re-writes it's properties to the index registry key with 0 then the crash occurs.
I'm thinking it's getting caught in a redundant loop somewhere?

Maybe try deleting or setting the index to null ("") if the number of actual entry's does equal zero and change it to an else if index > 0 for the next step that contains the do loop.

Maybe think about changing those bottom three if statements into a nested if statement or a step statement like While Wend?
Reply #7 from WinCustomize Forums Top
Your post seems to make a lot of sense, I'll try your advice tomorrow, today I'm busy with new year party organization :D happy new year to all!